Skip to content

Comments

update the docs for rearranged args#372

Closed
adamspofford-dfinity wants to merge 3 commits intomasterfrom
spofford/rearranged-args
Closed

update the docs for rearranged args#372
adamspofford-dfinity wants to merge 3 commits intomasterfrom
spofford/rearranged-args

Conversation

@adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity commented Aug 5, 2022

dfinity/sdk#2369 moved middle-of-the-command named arguments to the end of the command. This updates the docs to reflect the new CLI interface. Do not merge before dfx 0.12

@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for icportal ready!

Name Link
🔨 Latest commit 4d3bb0c
🔍 Latest deploy log https://app.netlify.com/sites/icportal/deploys/637d4a12ff58c6000847f22f
😎 Deploy Preview https://deploy-preview-372--icportal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review November 22, 2022 22:10
@adamspofford-dfinity adamspofford-dfinity requested review from a team as code owners November 22, 2022 22:10
2. Assign the `ic_admin` principal the `admin` role by running a command similar to the following using Candid syntax:

dfx canister --wallet=$(dfx identity get-wallet) call access_hello assign_role '((principal "c5wa6-3irl7-tuxuo-4vtyw-xsnhw-rv2a6-vcmdz-bzkca-vejmd-327zo-wae"),opt variant{admin})'
dfx canister call --wallet="$(dfx identity get-wallet)" access_hello assign_role '((principal "c5wa6-3irl7-tuxuo-4vtyw-xsnhw-rv2a6-vcmdz-bzkca-vejmd-327zo-wae"),opt variant{admin})'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dfx canister call --wallet="$(dfx identity get-wallet)" access_hello assign_role '((principal "c5wa6-3irl7-tuxuo-4vtyw-xsnhw-rv2a6-vcmdz-bzkca-vejmd-327zo-wae"),opt variant{admin})'
dfx canister call access_hello assign_role '((principal "c5wa6-3irl7-tuxuo-4vtyw-xsnhw-rv2a6-vcmdz-bzkca-vejmd-327zo-wae"),opt variant{admin})' --wallet="$(dfx identity get-wallet)"


``` bash
dfx --identity Miles canister call rust_profile_backend update '(record {name = "Miles"; description = "Great Dane"; keywords = vec {"Boston"; "mantle"; "three-legged"}})'
dfx canister call --identity Miles rust_profile_backend update '(record {name = "Miles"; description = "Great Dane"; keywords = vec {"Boston"; "mantle"; "three-legged"}})'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dfx canister call --identity Miles rust_profile_backend update '(record {name = "Miles"; description = "Great Dane"; keywords = vec {"Boston"; "mantle"; "three-legged"}})'
dfx canister call rust_profile_backend update '(record {name = "Miles"; description = "Great Dane"; keywords = vec {"Boston"; "mantle"; "three-legged"}})' --identity Miles


``` bash
dfx --identity Miles canister call rust_profile_backend getSelf
dfx canister call --identity Miles rust_profile_backend getSelf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dfx canister call --identity Miles rust_profile_backend getSelf
dfx canister call rust_profile_backend getSelf --identity Miles

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple spots left where --network can go after all of the positionals

@jessiemongeon1
Copy link
Contributor

This PR appears to be outdated/not needed. Closing this PR to clean up the repo. Please feel free to reopen if you think this should be revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants